This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Replace HashHelpers.Combine with HashCode.Combine in netcoreapp projects #40935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What's the effect on our benchmarks? |
hughbe
reviewed
Sep 9, 2019
Which ones in particular? HashCode.Combine is slower than HashHelpers.Combine; that's https://github.com/dotnet/coreclr/issues/26582. |
|
Merging to unblock mono. |
stephentoub
added
the
assembly-size
This was referenced Aug 27, 2020
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
…cts (dotnet/corefx#40935) Commit migrated from dotnet/corefx@8c221ca
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/dotnet/corefx/issues/25986